Stop splitting common operators #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that because you are allowed to define |
|
I changed how operators are recognized and I'll update the PR text. |
Jentsch
commented
Oct 9, 2024
| name: 'keyword.operator.arithmetic.scala' | ||
| }, | ||
| { | ||
| match: '(=|\\<|>)', |
There was a problem hiding this comment.
Here I think we shouln't match =, as a single = doesn't compare but defines things.
tgodzik
requested changes
Oct 11, 2024
Doesn't affect comparison, arithmetic nor logical. In the match `:+` the `+` became redundant, because it's contained in `opchar`. Discovered while working on scala#191.
'Longer' operators like -> aren't an arithmetic operator and than a comparison, but one operator.
With this the examples from [the documentation](https://docs.scala-lang.org/tour/operators.html) work.
Instead of dancing around around special operators we can just enumerate them now. This fixes a lot of edge cases.
Jentsch
force-pushed
the
fix-operators
branch
from
b996fae to
d868753
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the operators like
->,:+,=>,<-that are 'composed' from shorter operators like-and>. It also fixes operators like\/where\wasn't highlighted at all.The change looks quite drastic, but the changes in the snaps look fine to me. I'd would appraciate a second pair of eye to check if an special operator is missing.
A change where I'm not sure if we want it:
One could argue, the
-is realy the arithmetic operator here, as theexpressions
i -= 1most of the time meansi = i - 1.Btw. I don't think in
i = 1the=shouldn't be marked as a comparison but just as an operator.